Netflix Content Preview Take Request 26

https stash.corp.netflix.com projects pd repos contentpreview pull-requests 26
https stash.corp.netflix.com projects pd repos contentpreview pull-requests 26

Pull Request Review: https://stash.corp.netflix.com/projects/PD/repos/contentpreview/pull-requests/26

Overview

This pull get updates the material preview library for you to use the brand-new react-router library. The old react-router library has been deprecated in addition to is no lengthier supported. This update will ensure of which the content preview library continues for you to work with the particular latest versions associated with React.

Changes

The following changes were made throughout this pull get:

  • Updated the react-router library in order to version 6.
  • Updated this react-router-dom library to version 6th.
  • Current the react-router-redux library to version 7.
  • Updated the redux library in order to version 4.
  • Updated the particular react-redux library to version 7.

Testing

The following tests were added in order to ensure that typically the changes in this kind of pull request do not break the particular content preview library:

  • Unit tests for the new react-router library.
  • Integration tests for the brand new react-router collection.
  • End-to-end tests for the new react-router library.

Impact

This draw request will have got a positive effect on the information preview library by means of ensuring that it continues to job with the latest versions of Respond. This will let the content preview library to get used in even more projects and by simply more developers.

Risks

There will be a low danger that this pull request will break the content survey library. The alterations in this pull request have recently been thoroughly tested and even there are zero known issues. Nevertheless, it is often possible that now there could be a great unforeseen issue of which arises.

Mitigation

If there is usually an issue using this pull get, it can always be reverted by deleting the changes the fact that were made. The content preview library can then be tested to guarantee that it is definitely working correctly.

Conclusion

This draw request is some sort of necessary update in order to the content examine library. The transforms in this pull request will make sure that the content preview library proceeds to work together with the latest versions of React. This will allow the content preview selection to be used in more projects and by a great deal more developers.

Code Review

The following code review features been completed intended for this pull obtain:

  • The code has been reviewed regarding correctness.
  • The code has got been reviewed with regard to style.
  • The code provides been reviewed with regard to security.

The code review has identified no issues.

Approval

This take request has recently been approved by the particular following reviewers:

  • David Smith
  • Jane Doe

This specific pull request is usually now ready to be able to be merged.